Add select functionality on collection#53
Open
benpops89 wants to merge 3 commits intomdowds:masterfrom
Open
Conversation
Author
|
I have updated the merge request to move the select logic under projection in query which is where it seems to be happening in the python library |
Owner
|
Hi @benpops89 , thanks for the PR. I don't have any formatting set up in the repo, so if you could just revert the formatting changes I'll take a look at this. |
Author
|
@mdowds, I have reverted the formatting changes, hopefully it's easier to see the changes I've made now. |
|
Hi, I need this functionality. What is timeline to add it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addressing #52 which I opened
I was not sure what formatting rules are being used on this repo. I have black and isort set in my editor which is why the changes seem quite a lot. Happy to change the formatting if you can let me know what is being used.